Change severity rules

[amandel]

To get more targeted results especially for new setups I would propose to do either of:

1. Add a new severity level bug and allow only selected finders to report into this severity (definite nullpointer dereference, fails to close stream...). I also would then change the severity of the C&P detector to be between bug and error.
2. Move all error level findings into the warning severity except the ons that directly report a bug (see above). So things like tab in code, misplaced brace etc. would go to warning rather than error. I also would then change the severity of the C&P detector to be between warning and error.
3. Something completely different like introducing a new dimension reflecting the difference of finders that detect violations of code formating rules vs. potential bugs or resource leaks. (+ coverage data + metrics + c&p)

I assume b would be the least effort and does not have the risk to have to many severity levels and no clear rule decide in which level to put a finding in.

I'll take care for this change but it would be nice to hear your opinion about this change.

[amandel]

no comment?

[amandel]

Conclusion was to use the following severity levels:

1. bug
2. c&p
3. bug?
4. design
5. code-style
6. coverage
7. filtered

[amandel]

We did not define a level for info like TODO tags. Also I replaced the bug? with warning. So I now choose:

1. Severity.BUG
2. Severity.CPD
3. Severity.WARNING
4. Severity.DESIGN
5. Severity.CODE_STYLE
6. Severity.INFO
7. Severity.COVERAGE
8. Severity.FILTERED

[amandel]

See

Error: Failed to load processor javadoc

No macro or processor named 'javadoc' found

for the new severity class and its levels.

Open items are (besides some documentation):

• Define CSS-Colors for new severity-levels
• #27
• Adopt findbugs severities (bit strange because of the contribute package)
• Refine other severities (will be a ongoing process)
• Adopt CC xslt (package summary)