Project Report: fawkez

Packagesummary org.jcoderz.commons.connector.file

org.jcoderz.commons.connector.file.FsTestCase

LineHitsNoteSource
1  /*
2   * $Id: FsTestCase.java 1011 2008-06-16 17:57:36Z amandel $
3   *
4   * Copyright 2006, The jCoderZ.org Project. All rights reserved.
5   *
6   * Redistribution and use in source and binary forms, with or without
7   * modification, are permitted provided that the following conditions are
8   * met:
9   *
10   *    * Redistributions of source code must retain the above copyright
11   *      notice, this list of conditions and the following disclaimer.
12   *    * Redistributions in binary form must reproduce the above
13   *      copyright notice, this list of conditions and the following
14   *      disclaimer in the documentation and/or other materials
15   *      provided with the distribution.
16   *    * Neither the name of the jCoderZ.org Project nor the names of
17   *      its contributors may be used to endorse or promote products
18   *      derived from this software without specific prior written
19   *      permission.
20   *
21   * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS "AS IS" AND
22   * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
23   * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
24   * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS AND CONTRIBUTORS
25   * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
26   * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
27   * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
28   * BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
29   * WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
30   * OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
31   * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
32   */
33  package org.jcoderz.commons.connector.file;
34  
35  import java.util.Properties;
36  import java.util.logging.Level;
37  import java.util.logging.Logger;
38  import javax.resource.ResourceException;
39  import javax.resource.spi.ManagedConnectionFactory;
40  import junit.framework.TestCase;
41  import org.jcoderz.commons.connector.DefaultConnectionManager;
42  
43  
44  /**
45   * This class contains a set of methods used by all derived testcases.
46   *
47   */
48100(1)public abstract class FsTestCase
49        extends TestCase
50  {
51     /** The full qualified name of this class. */
5275    private static final transient String CLASSNAME = FsTestCase.class.getName();
53     /** The logger to use. */
54100    private static final transient Logger logger = Logger.getLogger(CLASSNAME);
55  
56100    private final ManagedConnectionFactory mMcf
57           = new FsManagedConnectionFactoryImpl();
58  
59     protected FsConnection getConnection ()
60     {
61100       return getConnection(null);
62     }
63  
64     protected FsConnection getConnection (final Properties props)
65     {
66100       FsConnection c = null;
67        try
68        {
69100          final FsConnectionFactory cf = (FsConnectionFactory) mMcf
70                 .createConnectionFactory();
71100          c = cf.getConnection(props);
72        }
730       catch (ResourceException e)
74        {
750          logger.log(Level.SEVERE,
76                 "Unexcpected error while connection's getting.", e);
77  
780          fail("Got an unexpected resource exception while connection's getting."
79                 + e.getMessage());
80100       }
81100       return c;
82     }
83  
84     /**
85      * @return Connection Manager
86      * @throws ResourceException thrown in error cases.
87      */
88     protected DefaultConnectionManager getConnectionManager ()
89           throws ResourceException
90     {
91100       final FsConnectionFactoryImpl cf = (FsConnectionFactoryImpl) mMcf
92              .createConnectionFactory();
93100       final DefaultConnectionManager cm
94              = (DefaultConnectionManager) cf.getConnectionManager();
95100(2)      return cm;
96     }
97  }

Findings in this File

c (1) 48 : 0 Type Javadoc comment is missing an @author tag.
i (2) 95 : 0 method org.jcoderz.commons.connector.file.FsTestCase.getConnectionManager() stores return result in local before immediately returning it (test code) Decreased severity from 'warning' for testcode.