The null check here is misplaced. if the variable is null you'll get a NullPointerException. Either the check is useless (the variable will never be "null") or it's incorrect.public class Foo { void bar() { if (a.equals(baz) || a == null) {} } }Additional info can be found at this http://pmd.sourceforge.net/rules/basic.html#MisplacedNullCheck site.
| 1 | org.jcoderz.phoenix.report.samples.SimplePmdFindings |
| [73:11] | |