View by Classes

Findings - Overview

info InefficientEmptyStringCheck (PMD)

String.trim().length()==0 is an inefficient way to validate an empty String.

String.trim().length() is an inefficient way to check if a String is really empty, as it creates a new String object just to check its size. Consider creating a static function that loops through a string, checking Character.isWhitespace() on each character and returning false if a non-whitespace character is found.

public class Foo {
    void bar(String string) {
        if (string != null && string.trim().size() > 0) {
		    doSomething();
        }
    }
}

    

Additional info can be found at this http://pmd.sourceforge.net/rules/strings.html#InefficientEmptyStringCheck site.