View by Classes

Findings - Overview

code-style SimplifyBooleanAssertion (PMD)

assertTrue(!expr) can be replaced by assertFalse(expr)

Avoid negation in an assertTrue or assertFalse test. For example, rephrase: assertTrue(!expr); as: assertFalse(expr);

public class SimpleTest extends TestCase {
 public void testX() {
  assertTrue("not empty", !r.isEmpty()); // replace with assertFalse("not empty", r.isEmpty())
  assertFalse(!r.isEmpty()); // replace with assertTrue(r.isEmpty())
 }
}

          

Additional info can be found at this http://pmd.sourceforge.net/rules/junit.html#SimplifyBooleanAssertion site.