View by Classes

Findings - Overview

code-style PositionLiteralsFirstInComparisons (PMD)

Further info on the wiki.
Position literals first in String comparisons - that way if the String is null you won't get a NullPointerException, it'll just return false.

class Foo {
 boolean bar(String x) {
  return x.equals("2"); // should be "2".equals(x)
 }
}


  

Additional info can be found at this http://pmd.sourceforge.net/rules/design.html#PositionLiteralsFirstInComparisons site.

6org.jcoderz.phoenix.cmpgen2.CmpGenerator
Position literals first in String comparisons [146:17],
Position literals first in String comparisons [150:22],
Position literals first in String comparisons [154:22],
Position literals first in String comparisons [158:22],
Position literals first in String comparisons [162:22],
Position literals first in String comparisons [166:22]
4org.jcoderz.phoenix.templategen.TemplateDescr
Position literals first in String comparisons [153:20],
Position literals first in String comparisons [161:25],
Position literals first in String comparisons [178:25],
Position literals first in String comparisons [183:25]
3org.jcoderz.commons.connector.http.transport.HttpClientConnectionImpl
Position literals first in String comparisons [329:11],
Position literals first in String comparisons [489:17],
Position literals first in String comparisons [493:22]
2org.jcoderz.phoenix.templategen.TemplateGeneratorServlet
Position literals first in String comparisons [92:16],
Position literals first in String comparisons [97:16]
2org.jcoderz.commons.taskdefs.Formatter
Position literals first in String comparisons [69:11],
Position literals first in String comparisons [73:16]
2org.jcoderz.commons.util.JarUtils
Position literals first in String comparisons [159:18],
Position literals first in String comparisons [159:39]
1org.jcoderz.phoenix.report.samples.SimplePmdFindings
Position literals first in String comparisons (sample) [91:11]
1org.jcoderz.phoenix.templategen.TemplateGenerator
Position literals first in String comparisons [120:11]